-
Notifications
You must be signed in to change notification settings - Fork 14
feat: kubo 0.38 interop and pin name support #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add name parameter to pin.add and pin.addAll - add names flag to pin.ls (auto-enabled with name filter) - filter undefined/null values in URL parameters - handle mixed arrays in normalise-input - add validation for conflicting options - add comprehensive tests Note: one test fails due to kubo bug fixed in unreleased commit 38be7908b. Re-test once kubo 0.38+ ships with the fix.
lidel
commented
Sep 17, 2025
update test to check metadata (mode/mtime) is properly sent to API and stored in UnixFS structure, retrievable via DAG API
- change kubo imports from named to default imports (CommonJS module) - fix import order for ipfs-unixfs in test file
kubo API doesn't return ProvideBufLen field in JSON response, default to 0 when missing to fix test failure
- replace arbitrary 'Fruit' key with 'Gateway.RootRedirect' - replace removed 'Discovery.MDNS.Interval' with 'Gateway.MaxConcurrentRequests' - add test for unknown config key rejection - kubo no longer allows arbitrary config keys
- respect IPFS_GO_EXEC env var in interface tests - document IPFS_GO_EXEC usage in README - add version logging to track which binary is used allows testing with development versions of kubo
lidel
added a commit
to ipfs/boxo
that referenced
this pull request
Sep 18, 2025
adds CheckIfPinnedWithType method to Pinner interface that allows checking specific pin types with optional name loading. this enables efficient pin operations like 'ipfs pin ls <cid> --names' without loading all pins. - CheckIfPinned now delegates to CheckIfPinnedWithType for consistency necessary for ipfs/js-kubo-rpc-client#343
This was referenced Sep 18, 2025
lidel
added a commit
to ipfs/boxo
that referenced
this pull request
Sep 18, 2025
…ames (#1035) * feat: add CheckIfPinnedWithType for efficient pin checks adds CheckIfPinnedWithType method to Pinner interface that allows checking specific pin types with optional name loading. this enables efficient pin operations like 'ipfs pin ls <cid> --names' without loading all pins. - CheckIfPinned now delegates to CheckIfPinnedWithType for consistency necessary for ipfs/js-kubo-rpc-client#343 * docs: add changelog entry for CheckIfPinnedWithType * test: add tests for CheckIfPinnedWithType tests cover: - type-specific pin checking (direct, recursive, indirect) - pin name loading with includeNames flag - multiple CIDs in single call - edge cases (not pinned, internal mode, invalid mode) - backward compatibility with CheckIfPinned
removed debug console.log statement that was causing eslint no-console rule violation
github-actions bot
pushed a commit
that referenced
this pull request
Oct 2, 2025
## [5.4.0](v5.3.0...v5.4.0) (2025-10-02) ### Features * kubo 0.38 interop and pin name support ([#343](#343)) ([32efafb](32efafb))
🎉 This PR is included in version 5.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds proper name support to
kubo-rpc-client
making them usable once Kubo 0.38 ships with necessary fixespin.add
andpin.addAll
pin.ls
(auto-enabled with name filter)TODO
ipfs pin ls
with--names
vs--name
ipfs pin ls <cid> --names
kubo#10970